Update examples/elm.json to be ready for Elm 0.19.1 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was setup to be ready for Elm 0.19.0 which means you see an error when trying to run the exmaple in Elm 0.19.1. Now that Elm 0.19.1 is released it seems, to me at least, to be a good idea for the examples to run by default on that version, and for the user to have to modify it to run a different version.
harrysarson
suggested changes
Jan 25, 2020
| @@ -1,25 +1,25 @@ | |||
| { | |||
| "type": "application", | |||
| "source-directories": [ | |||
| "." | |||
| "src" | |||
There was a problem hiding this comment.
This should not have been changed (the elm files are in the root examples directory)
|
Closing as I've not done anything on this in more than two years, so I'm unlikely to in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was setup to be ready for Elm 0.19.0 which means
you see an error when trying to run the exmaple in Elm 0.19.1.
Now that Elm 0.19.1 is released it seems, to me at least, to be
a good idea for the examples to run by default on that version,
and for the user to have to modify it to run a different version.