Code clean up while working on #114 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeeren
requested changes
Sep 13, 2019
cmeeren
approved these changes
Sep 14, 2019
|
Okay, seems all comments are resolved. Are you ready for this to be merged? |
TysonMN
force-pushed
the
#114_code_clean_up
branch
from
3e850f6
to
389f9bb
Compare
|
I squashed the commits. Ready now. Thanks :) |
|
Thanks for the work you're putting into improving Elmish.WPF! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #114, I made many small code improvements. All changes are meant to be behavior preserving. I find it helpful to not keep changes to myself for too long, so I thought I would contribute this PR now.