Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy process on stop #5

Merged
merged 4 commits into from
Nov 15, 2016
Merged

Destroy process on stop #5

merged 4 commits into from
Nov 15, 2016

Conversation

bdw429s
Copy link
Collaborator

@bdw429s bdw429s commented Nov 15, 2016

This seems to actually kill the tunnel.

@bdw429s
Copy link
Collaborator Author

bdw429s commented Nov 15, 2016

Hmm, this works when running server share stop, but not when stopping the server and the interceptor kicks in. That's because the first command kills all tunnels, but the second only kills tunnels whose names match. Since this project only lets you have one tunnel open at a time anyway, is there a reason the interceptor shouldn't just kill all tunnels as well?

@elpete
Copy link
Owner

elpete commented Nov 15, 2016

That should be fine. If one day we want to allow people with pro accounts, we can change it then.

@bdw429s
Copy link
Collaborator Author

bdw429s commented Nov 15, 2016

Ok, I updated the pull

@elpete elpete merged commit 81dadad into elpete:master Nov 15, 2016
@elpete
Copy link
Owner

elpete commented Nov 15, 2016

Thanks! I'll update and push a new version tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants