change reference from members to contacts #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drid @ramgarden @elplatt can I get a review on this? |
repoint URL references for members to contacts - it's possible to have the member module disabled, but these links create a dependency on a module that's loaded after the contact & user modules
|
Still need a review on this one? Or does it need to wait for the big merge
to release?
…On Mon, Oct 9, 2023 at 6:19 PM Chris Murray ***@***.***> wrote:
@drid <https://github.com/drid> @ramgarden <https://github.com/ramgarden>
@elplatt <https://github.com/elplatt> can I get a review on this?
—
Reply to this email directly, view it on GitHub
<#525 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAU4DTJ3P5UPZBQJTIBHS5LX6RZ5PAVCNFSM6AAAAAA5ZNCD72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTHE3TAOJRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ramgarden if you're happy to review I'll merge it into dev now, then when the other PRs are ready I'll do a merge into Main & create a release :) |
ramgarden
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repoint URL references for members to contacts - it's possible to have the member module disabled, but these links create a dependency on a module that's loaded after the contact & user modules