Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for generic types #76

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Conversation

Skleni
Copy link
Contributor

@Skleni Skleni commented Jul 1, 2022

Resolves #67.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #76 (296b744) into main (6046abd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1027      1045   +18     
  Branches       119       125    +6     
=========================================
+ Hits          1027      1045   +18     
Impacted Files Coverage Δ
...otNet/Packer/DeclarationGenerator/TypeConverter.cs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6046abd...296b744. Read the comment docs.

@elringus elringus merged commit 64599e0 into elringus:main Jul 1, 2022
@elringus
Copy link
Owner

elringus commented Jul 1, 2022

Merged, thank you! Will refactor a bit and push to nuget soon.

@Skleni
Copy link
Contributor Author

Skleni commented Jul 1, 2022

No rush, I don't think I depend on it any more. I wanted to reuse some OmniSharp LSP models, but they don't match the typescript implementation as closely as I thought, so I guess I'll have to define my own models anyway.

@elringus
Copy link
Owner

elringus commented Jul 1, 2022

@Skleni If you happen to be building a language server from scratch with dotnetjs, here's one I've made: https://github.com/Naninovel/Language (used in this VS Code extension: https://github.com/Naninovel/VSCode/tree/feat/vnext)

It's using C# backend w/o any deps and Microsoft's vscode-languageserver on the JS side. Could be useful as a reference.

@Skleni
Copy link
Contributor Author

Skleni commented Jul 1, 2022

Yes, that's what I'm doing (based on your comment here).

Thanks for the links, I'm sure they'll turn out useful! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generic function parameters
2 participants