Implement missing features to enable compatibility with python's meshio #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a parser for OFFSETS and CONNECTIVITY tags within legacy vtk files that mimic the way the xml file work. There is a new version of legacy vtk files (seemingly v5 and up) that specify cells via OFFSETS and CONNECTIVITY tags. This parser adds support for that. See issue #21 for exmaples. This commit addresses the parsing of the legacy files in that issue.
Added the ability to write cells in new offsets + connectivity format for vtk versions 5+. See issue #21 for details.
Usage of this function is replaced by the generic write_vec function implemented in the previous commit.
This is where prototype assets can be stored which are used for temporary testing or large files that should not be committed to the repo.
Since some files can give non uint8 type cell types, we explicitly cast everything to the right type instead of expecting it to be given correctly. This helps parse files generated by meshio (See issue #21)
One of the previous commits fixes the issue. This commit fixes the test for meshio generated files.
Clarify usage of xml and legacy formats, without renaming (yet).
This makes the results more consistent with paraview. It also passes on one additional testcase from pygmsh.
Each inline (non-appended) binary DataArray now supports compression in the same way appended data did before. This commit concludes fixes for all failing meshes from issue #21. The remaining pygmsh tests are now enabled.
|
This PR was superseded by #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #21. The changes involved were:
vtkio.