Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Includes a number of important bug fixes and updates summarized below.
struct
is changed to anenum
to distinguish between XML and Legacy file formats. Improve version handling #12pygmsh
ormeshio
can now be recognized byvtkio
. Thanks to @2pt0 for providing the issue and example script for generating test files. Unable to import various VTK and VTU file types #21vtkio
.Int64
.header_type
toUInt32
which is consistent with how ParaView interprets XML files withoutheader_type
specified.DataArrays
.TODO:
vtkio
work with future versions of quick-xml. The current implementation is more of a hack and has some serious limitations, which cannot make it upstream.