Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vimac icon #668

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Add Vimac icon #668

merged 3 commits into from
Nov 5, 2020

Conversation

FIGBERT
Copy link
Contributor

@FIGBERT FIGBERT commented Nov 3, 2020

Adds an icon for Vimac.

@vercel
Copy link

vercel bot commented Nov 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/elrumo/macosicons/qv6k18646
✅ Preview: https://macosicons-git-vimac.elrumo.vercel.app

@elrumo
Copy link
Owner

elrumo commented Nov 4, 2020

Thanks for the icon, looks great! There's just one thing and then I'll merge it, could you add a low res (256px) and high res .png of the icon to icons/png please? Or else they won't appear on the webiste.

Thanks!

@FIGBERT
Copy link
Contributor Author

FIGBERT commented Nov 4, 2020

Absolutely! I was wondering where those folders went, because when I first contributed they were in the top level. I'll add those to all the PRs I have open ASAP.

@elrumo
Copy link
Owner

elrumo commented Nov 5, 2020

Great, thanks! Soon there will be even more changes to the way icons are submitted, I've created a new version of the website where anyone will be able to submit icons and a dashboard for me to approve or get in touch with the creators if there are any issues.

@elrumo elrumo merged commit 8975c85 into elrumo:master Nov 5, 2020
Icons automation moved this from To commit to Done Nov 5, 2020
elrumo added a commit that referenced this pull request Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Icons
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants