V3 make workflowdefinition have readonly #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfmskywalker
reviewed
Jun 3, 2023
Comment on lines
7
to
15
| import { ActivityNodeShape } from './shapes'; | ||
| import { Activity, ActivityDeletedArgs, ActivityDescriptor, ActivitySelectedArgs, ChildActivitySelectedArgs, ContainerSelectedArgs, EditChildActivityArgs, GraphUpdatedArgs, WorkflowUpdatedArgs } from '../../models'; | ||
| import { createGraph } from './graph-factory'; | ||
| import { AddActivityArgs, Connection, Flowchart, FlowchartModel, FlowchartPathItem, LayoutDirection, RenameActivityArgs, UpdateActivityArgs } from './models'; | ||
| import { NodeFactory } from "./node-factory"; | ||
| import { Container } from "typedi"; | ||
| import { createActivityLookup, EventBus, flatten, PortProviderRegistry, walkActivities } from "../../services"; | ||
| import { ConnectionCreatedEventArgs, FlowchartEvents } from "./events"; | ||
| import { ContextMenuAnchorPoint, ContextMenuItem } from "../../components/shared/context-menu/models"; |
There was a problem hiding this comment.
Many changes in this PR relate to different code style settings between your and my IDE. Although I like your styling better, it would be best if you can adjust your settings (ideally, via some config file part of this repo) and update your PR to only include the relevant changes to support readonly workflows.
|
This PR looks good, I have tested it too, and it works well. If you could handle the style changes, then that would be perfect. |
sfmskywalker
approved these changes
Jun 8, 2023
…thub.com/herblinernexxbizz/elsa-core into v3_make_workflowdefinition_have_readonly
sfmskywalker
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it possible to have 'readonly' workflows