Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workflow inbox cleanup service #4327

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

sfmskywalker
Copy link
Member

@sfmskywalker sfmskywalker commented Aug 13, 2023

Closes #4295

=== auto-pr-body ===

Summary

  • Added new MemoryWorkflowInboxStore.cs to implement IWorkflowInboxStore interface
  • Created SaveAsync(), FindManyAsync() and DeleteAsync() methods for MemoryWorkflowInboxStore class
  • Added Filter() helper method to filter WorkflowInboxMessages

List of Changes:

  • Added IWorkflowInboxStore interface implementation for MemoryWorkflowInboxStore.cs class
  • Added constructor to MemoryWorkflowInboxStore.cs class that takes parameter of MemoryStore
  • Added SaveAsync() method to save WorkflowInboxMessage instances in MemoryWorkflowInboxStore.cs
  • Added FindManyAsync() method to search and retrieve WorkflowInboxMessages in MemoryWorkflowInboxStore.cs
  • Added DeleteAsync() method to delete WorkflowInboxMessages in MemoryWorkflowInboxStore.cs
  • Added Filter() helper method to filter WorkflowInboxMessages in MemoryWorkflowInboxStore.cs

Refactoring Target:

  • Revise the memory store to use a read-write lock for thread safety
  • Extract the filtering logic of the Filter() method into separate methods for readability
  • Add logging to the SaveAsync(), FindManyAsync(), and DeleteAsync() methods to log any potential errors or exceptions
  • Add unit tests to cover logic for MemoryWorkflowInboxStore class and its methods

@sfmskywalker sfmskywalker added enhancement New feature or request core This issue relates to the core library elsa 3 This issue is specific to Elsa 3 labels Aug 13, 2023
@sfmskywalker sfmskywalker self-assigned this Aug 13, 2023
@sfmskywalker sfmskywalker added this to the Elsa 3.0 RC2 milestone Aug 13, 2023
@sfmskywalker sfmskywalker merged commit f4ae684 into v3 Aug 13, 2023
2 checks passed
@sfmskywalker sfmskywalker deleted the v3-workflow-inbox-cleanup branch August 13, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This issue relates to the core library elsa 3 This issue is specific to Elsa 3 enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant