Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #548 - improperly connected activity #714

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

craigfowler
Copy link
Contributor

The activity I removed would never have been executed, because it is
not connected from either of the IfElse branches.
Since this is Elsa 1.x, I've fixed it using the cheapest/quickest possible
solution which is to just remove the misleading part of the sample.

The activity I removed would never have been executed, because it is
not connected from either of the IfElse branches.
Since this is Elsa 1.x, I've fixed it using the cheapest/quickest possible
solution which is to just remove the misleading part of the sample.
@craigfowler craigfowler merged commit 94b0a1d into master Mar 4, 2021
@craigfowler craigfowler deleted the feature/548-incorrect-connection-in-sample branch March 4, 2021 20:17
@sfmskywalker
Copy link
Member

sfmskywalker commented Mar 4, 2021

Interestingly enough, this example would have worked properly in Elsa 2. In Elsa 2, the If activity always returns a "Done" outcome after either the "True" or "False" branch completes.

@craigfowler
Copy link
Contributor Author

Sipke, did you install the time machine extension to Visual Studio?

When this codebase gets up to 88mph, you're gonna see some serious schtick 🤣

@craigfowler
Copy link
Contributor Author

Also, hopefully now we've got a new commit in master (since I reconfigured its recognition of long-lived branches), SonarCloud will recognise master as one. That should mean that it stops failing PRs for the wrong reasons 👀

@sfmskywalker
Copy link
Member

Ahhh that explains the failing build notifications I've been seeing (and blissfully ignoring 🙈 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants