Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed camelCase / PascalCase typo. #107

Merged
merged 2 commits into from Jan 27, 2018
Merged

Conversation

moltar
Copy link
Contributor

@moltar moltar commented Jan 24, 2018

Not sure if the actual content was meant to be this way (I just assumed). But there was a syntax problem / typo.

Copy link
Collaborator

@vpanjganj vpanjganj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ‘PascalCase’ folders are folders which contain an ‘index’ file which returns a react component. I think I failed to phrase it in a right way. :/

@moltar
Copy link
Contributor Author

moltar commented Jan 26, 2018

So should it be PascalCase/cameCase.js then?

@moltar
Copy link
Contributor Author

moltar commented Jan 26, 2018

Also, the page does not mention React anywhere in the README. I wasn't under assumption this was React-specific guideline. I think it should be generic for all JS projects, and add specificity, if necessary, clearly marking as so.

I don't think there is an established convention to use CamelCase for folder names for anything other than React components.

@vpanjganj
Copy link
Collaborator

In that case the bulletpoint after it should go as well. This was meant for internal use initially, and we mostly use react. But you’re also right about it being irrelevant. So let’s ditch them.

@moltar
Copy link
Contributor Author

moltar commented Jan 27, 2018

Removed React-specific naming conventions.

Although, it'd be useful to have naming conventions overall.

@vpanjganj vpanjganj merged commit 41c9949 into elsewhencode:master Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants