Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kingdom page and functionality #29

Merged
merged 4 commits into from
Nov 26, 2020
Merged

Add kingdom page and functionality #29

merged 4 commits into from
Nov 26, 2020

Conversation

elthran
Copy link
Owner

@elthran elthran commented Nov 26, 2020 •
edited
Loading

Ready because serializers will be done in the next branch

@elthran elthran marked this pull request as ready for review November 26, 2020 00:51
@klondikemarlen klondikemarlen marked this pull request as draft November 26, 2020 01:09
@elthran elthran marked this pull request as ready for review November 26, 2020 01:11
klondikemarlen
klondikemarlen approved these changes Nov 26, 2020
View reviewed changes
Copy link
Collaborator

@klondikemarlen klondikemarlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

:shipit:

@elthran elthran merged commit 0463041 into master Nov 26, 2020
@elthran elthran deleted the add-kingdom-page-and-functionality branch November 26, 2020 01:23
@elthran elthran mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klondikemarlen klondikemarlen klondikemarlen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elthran @klondikemarlen @jbrunner-github