Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sep 10 update #232

Merged
merged 5 commits into from Feb 9, 2020
Merged

Sep 10 update #232

merged 5 commits into from Feb 9, 2020

Conversation

Kirbyrawr
Copy link
Collaborator

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

fracek and others added 4 commits February 6, 2020 21:23
@fracek
Update web authentication to SEP 10 v1.3.0
92f9c66
@Kirbyrawr
Merge branch 'master' into sep-10-update
4814678
@Kirbyrawr
Fixed TimeBounds.cs error message.
0720193 
Fixed WebAuthentication VerifyTransactionThreshold method.
Added a lot of the tests of WebAuthentication (Still missing some)
@Kirbyrawr
Added rest of WebAuthentication tests.
e8b6a15 
Added error check in ValidateSigners.
@coveralls
Copy link

coveralls commented Feb 9, 2020 •
edited

Pull Request Test Coverage Report for Build 4slq98rclnst0io6

  • 66 of 70 (94.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.012%
Changes Missing Coverage Covered Lines Changed/Added Lines %
stellar-dotnet-sdk/TimeBounds.cs 2 3 66.67%
stellar-dotnet-sdk/WebAuthentication.cs 64 67 95.52%
Totals Coverage Status
Change from base Build y3yvcndhc65m1q7i: 0.2%
Covered Lines: 4339
Relevant Lines: 5104
💛 - Coveralls

@fracek
Copy link
Collaborator

fracek commented Feb 9, 2020

LGTM.

@fracek fracek merged commit 18a73fc into master Feb 9, 2020
@fracek fracek mentioned this pull request Feb 9, 2020
Closed
leighmcculloch
leighmcculloch reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fracek I took a quick peek at just the signature verification flow in VerifyTransactionSignatures and noticed one thing that I mentioned below.

stellar-dotnet-sdk/WebAuthentication.cs Show resolved Hide resolved
@elucidsoft elucidsoft linked an issue Feb 15, 2020 that may be closed by this pull request
Update challenge transaction helpers for SEP-10 v1.3.0 #230
Closed
@elucidsoft elucidsoft deleted the sep-10-update branch May 12, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fracek fracek fracek approved these changes

@leighmcculloch leighmcculloch leighmcculloch left review comments

@elucidsoft elucidsoft Awaiting requested review from elucidsoft

Assignees

@fracek fracek

@Kirbyrawr Kirbyrawr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update challenge transaction helpers for SEP-10 v1.3.0
5 participants
@Kirbyrawr @coveralls @fracek @elucidsoft @leighmcculloch