Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memo check to support muxed accounts #255

Merged
merged 2 commits into from Apr 29, 2020
Merged

Fix memo check to support muxed accounts #255

merged 2 commits into from Apr 29, 2020

Conversation

fracek
Copy link
Collaborator

@fracek fracek commented Apr 29, 2020 •
edited

If the destination of a payment is a muxed account we do not need to check for the memo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 84.859% when pulling db8735c on fix-memo-check into 80a95ba on protocol-13.

Kirbyrawr
Kirbyrawr approved these changes Apr 29, 2020
View reviewed changes
Copy link
Collaborator

@Kirbyrawr Kirbyrawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@elucidsoft elucidsoft merged commit 8f53a42 into protocol-13 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kirbyrawr Kirbyrawr Kirbyrawr approved these changes

@elucidsoft elucidsoft Awaiting requested review from elucidsoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fracek @coveralls @Kirbyrawr @elucidsoft