This repository has been archived by the owner on May 24, 2024. It is now read-only.
SEP-10 3.0 #285
Merged
SEP-10 3.0 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added homeDomain check in WebAuthentication.cs
leighmcculloch
approved these changes
Nov 9, 2020
| @@ -145,6 +145,9 @@ public static class WebAuthentication | |||
| if (operation.SourceAccount is null) | |||
| throw new InvalidWebAuthenticationException("Challenge transaction operation must have source account"); | |||
|
|
|||
| if (operation.Name.Split(' ')[0] != homeDomain) | |||
There was a problem hiding this comment.
💡 Clients will only ever read a transaction expecting a single home domain, but a server may wish to support multiple home domains and if the SDK wishes to support that use case the list of home domains passed into it maybe should be a collection. That's really up to you though for if that is an important use case to this SDK.
There was a problem hiding this comment.
Hi, this is fixed now, thank you!
fracek
approved these changes
Nov 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added homeDomain check in WebAuthentication.cs
Types of changes