Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Support passing in a string for balance id #294

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Conversation

duckmatt
Copy link
Contributor

@duckmatt duckmatt commented Dec 28, 2020

Fixes #293 with:

  • Adds support for full 36 bytes of balance id (4 bytes type followed by 32 bytes for the body)
    • Keeps support of 32 bytes to keep it as a non-breaking change
  • Allows for balance id to be passed in as a string

The tests I've added match the expected behaviour of the tests from the Java SDK which cover the same functionality: https://github.com/stellar/java-stellar-sdk/blob/32331b3a5a4cf62eb6820b5e975032b9ab13887c/src/test/java/org/stellar/sdk/OperationTest.java#L757

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@fracek fracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for this!

@fracek fracek merged commit a3c1b35 into elucidsoft:master Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support passing in a string for balance ID in ClaimClaimableBalanceOperation.Builder
2 participants