Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Muxed Account fields in OperationsResponses, EffectResponses and TransactionResponses and refactorization of operation responses tests. #321

Merged
merged 8 commits into from
Jun 13, 2021
Merged

Muxed Account fields in OperationsResponses, EffectResponses and TransactionResponses and refactorization of operation responses tests. #321

merged 8 commits into from
Jun 13, 2021

Conversation

Kirbyrawr
Copy link
Collaborator

@Kirbyrawr Kirbyrawr commented Jun 6, 2021 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Kirbyrawr Kirbyrawr self-assigned this Jun 6, 2021
@Kirbyrawr
Added Muxed accounts to TransactionResponse
c2fd715
@Kirbyrawr
Added operations tests and bugfix.
56e8c96 
- Fixed OperationResponse SourceAccountMuxedID field being string instead of long.
- Added AccountMergeOperationResponse muxed test.
- Added AllowTrustOperationResponse muxed test.
- Added ChangeTrustOperationResponse muxed test.
- Added ClawbackOperationResponse muxed test.
- Added CreateAccountOperationResponse muxed test.
- Added EndSponsoringFutureReservesResponse muxed test.
- Added ClaimClaimableBalanceOperationResponse muxed test.
- Added PaymentOperationResponse muxed test.
@Kirbyrawr
Fix whitespace.
b7b8ace
@Kirbyrawr
Added TransactionMuxed test and fixed whitespace.
685ae23
@Kirbyrawr
Added EffectResponses muxed tests.
42d2715 
- Fixed SellerMuxerID being string instead of long.
- Added separate test for TradePre100
@Kirbyrawr Kirbyrawr requested review from elucidsoft and fracek and removed request for elucidsoft June 6, 2021 15:58
@Kirbyrawr Kirbyrawr marked this pull request as ready for review June 6, 2021 15:58
@Kirbyrawr Kirbyrawr mentioned this pull request Jun 6, 2021
Closed
@Kirbyrawr Kirbyrawr linked an issue Jun 6, 2021 that may be closed by this pull request
Add support for additional _muxed and _muxed_id optional fields in Horizon's JSON responses #318
Closed
@Kirbyrawr Kirbyrawr requested a review from elucidsoft June 6, 2021 16:00
@fracek
Copy link
Collaborator

fracek commented Jun 9, 2021

What happens if the response does not contain a _muxed_id field? I think the field should become a nullable long to handle this case. I would also keep the old test files and add the new version (with muxed ids) to make sure we don't break backward compatibility.

@Kirbyrawr
Copy link
Collaborator Author

On it

@Kirbyrawr Kirbyrawr changed the title Muxed Account fields in OperationsResponses, EffectResponses and TransactionResponses Muxed Account fields in OperationsResponses, EffectResponses and TransactionResponses and refactorization of operation responses tests. Jun 13, 2021
fracek
fracek reviewed Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@fracek fracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fracek fracek merged commit e10e875 into master Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fracek fracek fracek approved these changes

@elucidsoft elucidsoft Awaiting requested review from elucidsoft

Assignees

@Kirbyrawr Kirbyrawr

Labels
horizon-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for additional _muxed and _muxed_id optional fields in Horizon's JSON responses
2 participants
@Kirbyrawr @fracek