Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCA-38 protocol #3

Merged
merged 3 commits into from
Aug 31, 2020
Merged

RCA-38 protocol #3

merged 3 commits into from
Aug 31, 2020

Conversation

frawau
Copy link
Contributor

@frawau frawau commented Aug 31, 2020

I am not sure if you accept PR, but here is one. It adds RCA-38 protocol. This is used by TCL TV's.
I did not test it with real devices yet, but IrScrutinizer seems to recognise the generated code alright.

This coding accepts devices 0-15 and OBC 0-255

The encoding is quite simple
device (4 bits) OBC (8 bits) device complement (4 bits) OBC complement (8 bits)

@elupus
Copy link
Owner

elupus commented Aug 31, 2020

Nice! Think you can add a minimal test? I know there are not much testing as is. But since I have no devices for this.

@frawau
Copy link
Contributor Author

frawau commented Aug 31, 2020

Nice! Think you can add a minimal test? I know there are not much testing as is. But since I have no devices for this.

I went and testted it on my system with a Broadlink RM Pro as the sending device, and it all worked fine. The target device was a TCL Android TV ( device 15) and I tested:
Toggle on/off (OBC 42)
Discrete On (OBC 51)
Discrete Off (OBC 184) (sent twice to avoid out-of-screensaver issue)
Volume Up (OBC 47)
Volume Down (OBC 46)
Mute Toggle (OBC 63)

And a few others.

What type of testing do you have in mind?

@elupus
Copy link
Owner

elupus commented Aug 31, 2020

Pytest check in the tests subdirectory. Ie just verify that some known codes generate the expected sequence.

@elupus
Copy link
Owner

elupus commented Aug 31, 2020

Thank you!

@elupus elupus merged commit 219c4b3 into elupus:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants