DRY up how attributes are deserialized #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaulagiri
commented
Feb 9, 2018
| @@ -7,7 +7,8 @@ export default Factory.extend({ | |||
| name: function(i) { | |||
| return `User ${i}`; | |||
| }, | |||
| type: 'User', | |||
| // needs to be the actual related model name for Ember Data reasons? 🤔 | |||
| type: 'github-user', | |||
There was a problem hiding this comment.
there is something funky happening here with how the mirage record is getting serialized which required this to get the tests to behave. Trying things in a real app I'm not seeing a similar issue.
elwayman02
reviewed
Feb 9, 2018
|
|
||
| export default DS.RESTSerializer.extend({ | ||
| keyForAttribute(attr) { |
elwayman02
approved these changes
Feb 9, 2018
Dhaulagiri
force-pushed
the
br-serial
branch
from
e2d16f7
to
e30a11d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
This should make it simpler to add additional properties without needing to manually serialize each and every one