Skip to content

Commit

Permalink
#1: Add test case for panic when trying to store response without tex…
Browse files Browse the repository at this point in the history
…tures
  • Loading branch information
erickskrauch committed Apr 29, 2019
1 parent f213ed4 commit 94b930f
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 16 deletions.
19 changes: 3 additions & 16 deletions api/mojang/queue/in_memory_textures_storage.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package queue

import (
"errors"
"sync"
"time"

Expand Down Expand Up @@ -71,21 +70,9 @@ func (s *inMemoryTexturesStorage) StoreTextures(textures *mojang.SignedTexturesR
s.lock.Lock()
defer s.lock.Unlock()

var texturesProp *mojang.Property
for _, prop := range textures.Props {
if prop.Name == "textures" {
texturesProp = prop
break
}
}

if texturesProp == nil {
panic(errors.New("unable to find textures property"))
}

decoded, err := mojang.DecodeTextures(texturesProp.Value)
if err != nil {
panic(err)
decoded := textures.DecodeTextures()
if decoded == nil {
panic("unable to decode textures")
}

s.data[textures.Id] = &inMemoryItem{
Expand Down
15 changes: 15 additions & 0 deletions api/mojang/queue/in_memory_textures_storage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,21 @@ func TestInMemoryTexturesStorage_StoreTextures(t *testing.T) {
assert.Equal(texturesWithSkin, result)
assert.Nil(err)
})

t.Run("should panic if textures prop is not decoded", func(t *testing.T) {
assert := testify.New(t)

toStore := &mojang.SignedTexturesResponse{
Id: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
Name: "mock",
Props: []*mojang.Property{},
}

assert.PanicsWithValue("unable to decode textures", func() {
storage := CreateInMemoryTexturesStorage()
storage.StoreTextures(toStore)
})
})
}

func TestInMemoryTexturesStorage_GarbageCollection(t *testing.T) {
Expand Down

0 comments on commit 94b930f

Please sign in to comment.