Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next: Remove unrequired dependencies #78

Closed
elycruz opened this issue Aug 3, 2021 · 1 comment
Closed

next: Remove unrequired dependencies #78

elycruz opened this issue Aug 3, 2021 · 1 comment
Assignees
@elycruz

Comments

@elycruz
Copy link
Owner

elycruz commented Aug 3, 2021

We have several dependencies which are not really required anymore (babel, pify, etc.). Removing these plugins and writing the plugins source in a more idiomatically supported way (in way already supported by node v12+) will keep the plugin a bit more lean and make the journey from code edits to tests a bit faster (we currently have to rebuild the plugins sources, on every edit, before running tests).
@elycruz elycruz self-assigned this Aug 3, 2021
elycruz added a commit that referenced this issue Aug 14, 2021
@elycruz
#78 - Progress on validating tests after plugin code reorg/refactor.
2f330a9
elycruz added a commit that referenced this issue Aug 14, 2021
@elycruz
#78 - All tests re-enabled. Refinements to plugin code.
db37ace
elycruz added a commit that referenced this issue Aug 19, 2021
@elycruz
#78 - Downgraded typescript version. Rebuilt artifacts.
1011b11
elycruz pushed a commit that referenced this issue Aug 19, 2021
Revert "#78 - Downgraded typescript version. Rebuilt artifacts."
bd77cad 
This reverts commit 1011b11.
elycruz pushed a commit that referenced this issue Aug 20, 2021
#78 - Rolled back rollup and @rollup/pluginutil modules (rollup is no…
77dd23f 
…w at the latest 1.x.x version, and we're now using rollup-plugin-util ^2.8.2). Added rollup bundles types to 'src/types'. Added typing information to 'src/index'. Removed calls to \outputBundle.close();\, since we're now using rollup ^1.32.x. Re-enabled the removal of the tests artifacts output directory in 'test/index'.
elycruz added a commit that referenced this issue Aug 21, 2021
@elycruz
#78 - Rerverted dependecy versions to pre version 1.2.4 (enables lega…
9b31724 
…cy projects to continue using the plugin).
elycruz added a commit that referenced this issue Aug 21, 2021
@elycruz
#78 - Removed babel.config.json - file no longer required (since we'r…
cccf2f2 
…e using typescript for environment targeting).
elycruz added a commit that referenced this issue Aug 21, 2021
@elycruz
#78 - Removed unrequired tsconfig.spec file. Added es module output t…
35b9bcc 
…est. Performed minor cleanup in test/index.
elycruz added a commit that referenced this issue Aug 21, 2021
@elycruz
#78 - Added test for 'cjs' output.
01f0bbb
elycruz added a commit that referenced this issue Aug 21, 2021
@elycruz
#78 - Changed method call in test.
50d7425
elycruz added a commit that referenced this issue Aug 21, 2021
@elycruz
Merge pull request #79 from differui/issue-#78-unrequired_deps_remove
4fadd4a 
Issue #78 unrequired deps remove and repo upgrade to typescript
elycruz added a commit that referenced this issue Aug 21, 2021
@elycruz
#78 - Updated src/index to enforce file import priorty in default sas…
d3b6505 
…s importer - Before we were just pushing sass file bundles into styles array without caring for the file order - we had one synchronous call but then had an asynchronous call after; This change ensures that the file import/process priority is kept on every subsequent 'rollup.rollup' call (etc.).
@elycruz
Copy link
Owner Author

elycruz commented Aug 21, 2021

Issue resolved in PR #79 along with commits 06f9d32 and d3b6505, in dev branch.

@elycruz elycruz closed this as completed Aug 21, 2021
elycruz added a commit that referenced this issue Aug 22, 2021
@elycruz
#78 - Ran 'npm i', package.json auto-reformated.
34af007
@elycruz elycruz mentioned this issue Aug 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elycruz elycruz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elycruz