Repo to typescript and Deps cleanup #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te projects that depend on node 10 or can't upgrade to node >= 12 yet). Updated index.test.s to clear out tests artifacts 'before' and 'after' tests run - Ensures test results are reproducible.
This reverts commit 1011b11.
…w at the latest 1.x.x version, and we're now using rollup-plugin-util ^2.8.2). Added rollup bundles types to 'src/types'. Added typing information to 'src/index'. Removed calls to \outputBundle.close();\, since we're now using rollup ^1.32.x. Re-enabled the removal of the tests artifacts output directory in 'test/index'.
…cy projects to continue using the plugin).
…e using typescript for environment targeting).
…est. Performed minor cleanup in test/index.
Issue #78 unrequired deps remove and repo upgrade to typescript
… - Instead using try/catch we run 'resolve' asynchronously and call 'done' callback with result, this should resolve out of order bundle output we sometimes see when running tests; E.g., sometimes we expect 'body{color:red}body{color:green}' but we get 'body{color:green}body{color:red}':.
…s importer - Before we were just pushing sass file bundles into styles array without caring for the file order - we had one synchronous call but then had an asynchronous call after; This change ensures that the file import/process priority is kept on every subsequent 'rollup.rollup' call (etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #78 .