Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to choose default/darker shimmer colors #26

Merged
merged 4 commits into from
Aug 13, 2018

Conversation

ema987
Copy link
Contributor

@ema987 ema987 commented Aug 3, 2018

fixes issue #20

Copy link
Owner

@elye elye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.
I suggest don't need to have 2 custom attributes (defaultColor, darkerColor), but instead of one (customColor).
And when that exist, both bold and non bold would use that instead of the default one.
If possible, make one of the text line in the sample app to use the customColor, and amend the readme to have the feature.
We want to minimize the custom attributes to make it easier to use.
Thanks.

@ema987
Copy link
Contributor Author

ema987 commented Aug 7, 2018

Hi @elye, thank you for your reply!
I've made changes following your suggestions. Code is basically as previous commits besides that now custom_color attribute will override both defaultColor and darkerColor used in the CustomViews.
I've updated the readme, too.
It should be ok now, but if it's not, just let me know!

@elye elye merged commit 1d87aab into elye:master Aug 13, 2018
@elye elye mentioned this pull request Aug 13, 2018
@ema987 ema987 deleted the customShimmerColor branch February 4, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants