Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Common Properties TitleEditor #419

Closed
aqtang opened this issue Dec 10, 2020 · 3 comments
Closed

Improve Common Properties TitleEditor #419

aqtang opened this issue Dec 10, 2020 · 3 comments
Assignees
@aqtang
Labels
Properties

Comments

@aqtang
Copy link
Contributor

aqtang commented Dec 10, 2020

Updated design for the title component of Common Properties RHS flyouts, with support for an optional icon/label.

image

The edit icon should sit next to the title instead of at the end on the right. Editing the title should cause the edit icon to disappear, and editing should end on loss of focus.
@aqtang aqtang self-assigned this Dec 10, 2020
@quarryboy
Copy link

@aqtang is it safe to assume we will have truncation made available for when the title is too long?

@aqtang
Copy link
Contributor Author

aqtang commented Dec 14, 2020

@quarryboy Yes, we'll want that behavior

@aqtang
Copy link
Contributor Author

aqtang commented Dec 14, 2020

image

@aqtang aqtang mentioned this issue Dec 16, 2020
Merged
aqtang pushed a commit to aqtang/canvas that referenced this issue Dec 16, 2020
Merge branch 'master' into elyra-ai#419-title-update
9f9b221
@aqtang aqtang mentioned this issue Dec 16, 2020
Closed
matthoward366 pushed a commit that referenced this issue Dec 17, 2020
@aqtang
#419 Improve Common Properties TitleEditor (#425)
030265f
@aqtang aqtang closed this as completed Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aqtang aqtang

Labels
Properties
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quarryboy @aqtang @tomlyn