Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KF Dex authentication bug #1642

Merged
merged 2 commits into from May 7, 2021
Merged

Fix KF Dex authentication bug #1642

merged 2 commits into from May 7, 2021

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented May 5, 2021

This PR

What changes were proposed in this pull request?

  • Fix faulty code

  • Add log message for problem determination, should authentication fail

     Kubeflow authentication info: {'endpoint': 'http://custard1.fyre.ibm.com:31380', 'endpoint_response_url': 'http://custard1.fyre.ibm.com:31380/dex/auth/local?req=ywzv...cy', 'endpoint_secured': True, 'authservice_session_cookie': None}
    
  • Add proper error message

    image

How was this pull request tested?

  • connect to unsecured KF without credentials in the RTC (expected to succeed)
  • connect to unsecured KF with credentials in the RTC (expected to succeed)
  • connect to unsecured KF with only user name defined in the RTC (expected to succeed)
  • connect to unsecured KF with only password defined in the RTC (expected to succeed)
  • connect to secured KF without credentials in the RTC (expected to fail)
  • connect to secured KF with invalid credentials in the RTC (expected to fail)
  • connect to secured KF with only user name defined in the RTC (expected to fail)
  • connect to secured KF with only password defined in the RTC (expected to fail)
  • connect to secured KF with valid credentials in the RTC (expected to succeed)

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines platform: pipeline-Kubeflow Related to usage of Kubeflow Pipelines as pipeline runtime labels May 5, 2021
@ptitzler ptitzler added this to the 2.3.0.beta2 milestone May 5, 2021
@elyra-bot
Copy link

elyra-bot bot commented May 5, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler

This comment has been minimized.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ptitzler - this looks good and I'm approving from a code perspective. I can't test this, but trust you'll be doing that. My only comment was a nit regarding the log level that feels more troubleshooting-related than informational.

elyra/pipeline/processor_kfp.py Outdated Show resolved Hide resolved
@ptitzler
Copy link
Member Author

ptitzler commented May 5, 2021

All tests completed as expected, including informal test of debug output.

@lresende lresende merged commit e39f87a into elyra-ai:master May 7, 2021
@ptitzler ptitzler deleted the i1636 branch May 7, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines platform: pipeline-Kubeflow Related to usage of Kubeflow Pipelines as pipeline runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Kubeflow authentication/authorization errors
3 participants