Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize KFP endpoint URL #1711

Merged
merged 2 commits into from May 29, 2021
Merged

Normalize KFP endpoint URL #1711

merged 2 commits into from May 29, 2021

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented May 28, 2021

This PR

The code in the process and export methods already assumed that the URL does not end with /, as seen in https://github.com/elyra-ai/elyra/blob/master/elyra/pipeline/processor_kfp.py#L85, https://github.com/elyra-ai/elyra/blob/master/elyra/pipeline/processor_kfp.py#L231, and https://github.com/elyra-ai/elyra/blob/master/elyra/pipeline/processor_kfp.py#L235

What changes were proposed in this pull request?

How was this pull request tested?

  • Created RTC with trailing / in KFP API URL
  • Ran pipeline
  • Exported pipeline to KFP DSL and ran it

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented May 28, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added this to the 2.3.0 milestone May 28, 2021
@akchinSTC akchinSTC self-requested a review May 28, 2021 21:35
@ptitzler ptitzler added component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines platform: pipeline-Kubeflow Related to usage of Kubeflow Pipelines as pipeline runtime labels May 28, 2021
@lresende lresende merged commit 6942e27 into elyra-ai:master May 29, 2021
@ptitzler ptitzler deleted the i1605 branch July 6, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines platform: pipeline-Kubeflow Related to usage of Kubeflow Pipelines as pipeline runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KFP pipeline run link does not work if the KFP API endpoint ends with "/"
3 participants