Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit test file to proper test directory #2452

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

karlaspuldaro
Copy link
Member

@karlaspuldaro karlaspuldaro commented Feb 7, 2022

Following organization guidelines from the Elyra testing documentation, front end unit tests should be located in a folder called test in the src directory of the package being tested.

What changes were proposed in this pull request?

This PR moves pipeline-hooks.spec.ts test file from src/ into src/test/ location, as per documentation.

How was this pull request tested?

Ran make test-ui-unit and checked expected tests are still running.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Feb 7, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC akchinSTC merged commit 7ba3488 into elyra-ai:master Feb 8, 2022
@lresende lresende added this to the 3.6.0 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants