Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added development environment dockerfile and requirements file #2808

Merged
merged 4 commits into from
Jul 27, 2022

Conversation

salonee13
Copy link
Contributor

@salonee13 salonee13 commented Jun 28, 2022

What changes were proposed in this pull request?

Added two lines checking for node version and yarn version, this would make it easier for people down the line while they are in the process of installing and setting up the elyra environment to check to see if they have the right version of node and yarn installed.

How was this pull request tested?

We would start up the container and run make install, if everything ran smoothly and the command ran with no errors we can assume we had node and yarn properly installed.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Jun 28, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler linked an issue Jun 28, 2022 that may be closed by this pull request
@ptitzler ptitzler added the component:build build and build related issues(dependencies and docker) label Jun 28, 2022
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets update the description as well to something well...more descriptive...lol
We want to let people know what they are getting with this new pull request(no need to describe the changes) hint: its what @salonee13 had said during our webex, making things easier for people down the line.
Also how did we test this, its absolutely fine to say we just started up the container with the image and tried running make install but you should elaborate more.

Updates to documentation:
We also want to update the docs to reflect how people can use this new image. Take a look at docs/source/developer_guide/development-workflow.md. We probably want to update the requirements section with an OR and add this image as an option for use.
Also lets add another section that describes how to start the container and map the correct directories to the container e.g. the docker run .... cmd I gave you.

examples/Dockerfile Outdated Show resolved Hide resolved
examples/Dockerfile Outdated Show resolved Hide resolved
examples/requirements Outdated Show resolved Hide resolved
@akchinSTC akchinSTC self-requested a review July 27, 2022 20:12
@akchinSTC akchinSTC merged commit ef4cba3 into elyra-ai:main Jul 27, 2022
@akchinSTC akchinSTC changed the title added dockerfile and requirements file Added development environment dockerfile and requirements file Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use docker for development to support different environments
5 participants