Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom export file name #2999

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

salonee13
Copy link
Contributor

Fixes #1417

What changes were proposed in this pull request?

Added functionality that allows the user to change the export file name to their own custom name if needed, if not, keeps it as the export path name

This shows the default export name:
export_pt1

This shows that it allows you to customize the export name to whatever you want:
export_pt2

This shows that the file exports and saves successfully with the custom export name:
export_pt3

How was this pull request tested?

Tested manually, see screenshots shown above. After the integration tests run, we will add a test to make sure this functionality works.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Nov 4, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really great!

Could we add some space beneath the export name field to bring it in like with how it looks in the submission dialog (shown below)?

Screen Shot 2022-11-07 at 2 26 42 PM

@karlaspuldaro
Copy link
Member

Thank you @salonee13 for implementing this enhancement, it looks great and works as expected :)
I only had one comment regarding the styling but everything else looks good to me!

For the integration test, you can add a new file (maybe call it pipelineexport.ts) to the integration tests folder.
One test case should be sufficient, and the workflow/commands would look something like:

  1. create a runtime config
  2. open a pipeline test file (helloworld.pipeline)
  3. click export button
  4. edit export name to something else
  5. select the expected runtime config
  6. press ok
  7. check export name is in the succeeded dialog
  8. press ok o the succeeded dialog
  9. check the new file is listed in the file browser

@ptitzler
Copy link
Member

ptitzler commented Nov 8, 2022

Could you also change the order in which information is rendered and rename the label to Export Filename?

image

By moving the filename input to the bottom we group related information: the first inputs are specific to the runtime configuration that will be applied and the last three are specific to the exported file that will be produced:

  • choose a file format
  • choose a filename
  • choose whether to overwrite the file if it already exists

Salonee added 2 commits November 22, 2022 16:21
…me to their own custom name if needed, if not, keeps it as the export path name

Signed-off-by: Salonee <saloneepatel13@gmail.com>
…ormat of the export box

Signed-off-by: Salonee <saloneepatel13@gmail.com>
Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving as-is because we decided offline to add the above-mentioned integration test a follow-up issue/PR

Thank you so much, Salonee! I'll be getting a lot of use out of this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline export: allow for custom export file name
5 participants