Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and update KFP processor tests #3022

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

ptitzler
Copy link
Member

Closes #3002

Signed-off-by: Patrick Titzler ptitzler@us.ibm.com

What changes were proposed in this pull request?

  • Moved tests from elyra/tests/pipeline/kfp/test_processor_kfp.py that were not KFP specific to elyra/tests/pipeline/test_processor.py
  • Added new fixtures and supporting functions in elyra/tests/pipeline/kfp/conftest.py to simplify test implementation
  • Added tests to elyra/tests/pipeline/kfp/test_processor_kfp.py
  • Improved existing tests in elyra/tests/pipeline/kfp/test_processor_kfp.py
  • Created new KFP test artifacts in elyra/tests/pipeline/resources/test_pipelines/kfp

How was this pull request tested?

  • pytest -vv elyra/tests/pipeline/kfp/test_processor_kfp.py
  • pytest -vv elyra/tests/pipeline/test_processor.py

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added the component:test Test-related label Nov 19, 2022
@ptitzler ptitzler added this to the 3.14.0 milestone Nov 19, 2022
@elyra-bot
Copy link

elyra-bot bot commented Nov 19, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Nov 19, 2022
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added sizing: S and removed status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. labels Nov 21, 2022
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner now! This is great 👏

elyra/tests/pipeline/test_processor.py Outdated Show resolved Hide resolved
elyra/tests/pipeline/kfp/conftest.py Outdated Show resolved Hide resolved
elyra/tests/pipeline/kfp/conftest.py Outdated Show resolved Hide resolved
elyra/tests/pipeline/kfp/conftest.py Outdated Show resolved Hide resolved
elyra/tests/pipeline/kfp/conftest.py Show resolved Hide resolved
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler merged commit c7d9632 into elyra-ai:main Nov 29, 2022
@ptitzler ptitzler deleted the improve-code-gen-tests branch November 29, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more KFP code generation tests
2 participants