Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for gifs #327

Merged
merged 3 commits into from
Sep 26, 2021
Merged

feat: added support for gifs #327

merged 3 commits into from
Sep 26, 2021

Conversation

viglioni
Copy link
Contributor

Goal

  • Use gif as dashboard banner

to do it

  • verify if banner is a gif
  • if yes, animate it
  • obs.: to do so, I had to add a new way of setting spec, I'm not sure why but the way it was before, it was messing the gif quality.

Example:

In my configs:

(setq dashboard-startup-banner  "path/to/carlton.gif")
dashboard.gif.carlton.mp4

@jcs090218 jcs090218 self-requested a review September 25, 2021 02:45
jcs090218
jcs090218 reviewed Sep 25, 2021
View reviewed changes
Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make our CI happy? Thanks!

@viglioni
Copy link
Contributor Author

I think it will pass now! :)
But the workflow is not re-running automatically 🤔

@jcs090218 jcs090218 merged commit 44a6bd9 into emacs-dashboard:master Sep 26, 2021
@jcs090218
Copy link
Member

Thank your for contributing to emacs-dashboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcs090218 jcs090218 jcs090218 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@viglioni @jcs090218