New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal: Rewrite #324, add support for indicating ssh and program running in terminal buffer name #325 #331
Conversation
这是什么语法?terminal ssh一般是这样的:
|
抱歉,您一定是产生了误解,
|
懂了,我之前无法测试成功,看不到更改后的buffer-name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在无法判断ssh成功,destination还是我本地。在我处于ssh状态的时候executing_command一直显示的是我上一条command:changed_directory ~/ changed_destination 本地 changed_executing_command ssh
还有,进入ssh后,changed_directory最好显示服务器里面的pwd
app/terminal/index.html
Outdated
var ssh_re = /]0;(.*?):/g; | ||
var re = /:([^\x07].*?)\x07/g; | ||
ssh_arr = ssh_re.exec(msg.data) | ||
arr = re.exec(msg.data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在我ssh后这儿的bug有点多,match可能有点脆弱了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我这里一切正常,无论何种情况,可能是不同环境的msg不一样
您好,我这里一切正常,changed_directory也是显示的服务器里面的 您能否提供一下您的环境和ssh服务器的环境,并在这里插入 |
目前master有时会出现以下错误:
回头看看有没有被你新commit修好 |
6ec8f9d
to
c02ecc3
Compare
更新:
我进行了大量测试,尚未发现任何问题,如果您那里还是ssh有问题,可能匹配需要分类处理,需要专开issue搜集不同terminal的message信息
这个Bug应该是execute_js没做好类型转换,我已经在上一个Commit重写了update_title方法,理论上没有这个问题了 |
你可以用
我测试了一下别的服务器,没问题了,原因出在使用的TERMINAL不同。 目前这个匹配方式过于依赖terminal,比如这么做就会出问题:
|
在跑个别command后, 在众多复杂的可能性下,ssh_re几乎无法不出bug,这个方案不一定可行。 现在PR有点复杂了,我建议将它拆分成几个分别提交:
|
Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
Terminal: Rename buffer when running programme as in #331
Rewrite #324 so that the app won't exit without notification when launching it.
Add support for renaming terminal buffer under ssh, an example of terminal buffer name under ssh is provided as follows:
user@example.com:~/
Add support for renaming terminal buffer when running a program, an example of terminal buffer name when running a program is provided as follows:
test- ~/