Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed define-obsolete-function-alias in emacs 28 #509

Merged
merged 1 commit into from
Jan 12, 2021
Merged

fixed define-obsolete-function-alias in emacs 28 #509

merged 1 commit into from
Jan 12, 2021

Conversation

zsxh
Copy link
Contributor

@zsxh zsxh commented Jan 12, 2021

The 'when' argument of make-obsolete and related functions is
mandatory since https://emba.gnu.org/emacs/emacs/-/commit/32c6732d16385f242b1109517f25e9aefd6caa5c

The use of those functions without a 'when' argument was marked
obsolete back in Emacs-23.1. The affected functions are:
make-obsolete, define-obsolete-function-alias, make-obsolete-variable,
define-obsolete-variable-alias.

@zsxh
fixed define-obsolete-function-alias in emacs 28
1288aef 
The 'when' argument of `make-obsolete` and related functions is
mandatory since commit/32c6732d16385f242b1109517f25e9aefd6caa5c in
emacs master branch.
@manateelazycat manateelazycat merged commit a4d2483 into emacs-eaf:master Jan 12, 2021
@tangxinfa tangxinfa mentioned this pull request Mar 23, 2021
Merged
@lbolla lbolla mentioned this pull request Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zsxh @manateelazycat