Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r-completion.elc to Makefile #150

Merged
merged 1 commit into from
Mar 4, 2015
Merged

Conversation

dickoa
Copy link
Contributor

@dickoa dickoa commented Mar 4, 2015

ess-r-completion is not byte-compiled therefore not sent to /usr/share/emacs/site-lisp for people using make install it creates some problem

mmaechler added a commit that referenced this pull request Mar 4, 2015
Add r-completion.elc to Makefile
@mmaechler mmaechler merged commit acac12e into emacs-ess:master Mar 4, 2015
@mmaechler
Copy link
Member

Thank you.
The reason this was never detected: It seems that all ESS core developers work out of the build directory and never use 'make install' ... which is at least true for me. ;-)

@vspinu
Copy link
Member

vspinu commented Mar 5, 2015

Thanks Ahmadou. I always keep forgetting about makefiles :(

@mmaechler
Copy link
Member

Actually. There's more broken:

cd lisp
\rm -f *.elc
make

very quickly ends in an error that `cl-lib is not found .... which is a bit strange, as interactively it is found well when (require 'cl-lib) is encountered inside ess-completion.el

I'd be grateful for another patch ... as I'm not detecting where the problem is (Emacs 24.3).

Martin

@dickoa
Copy link
Contributor Author

dickoa commented Mar 11, 2015

I can't reproduce this error on a fresh install from the latest commit.

My specs are the following
Emacs version: GNU Emacs 24.4.1
Linux version (Arch Linux): Linux dickoa 3.18.6-1-ARCH #1 SMP PREEMPT Sat Feb 7 08:44:05 CET 2015 x86_64 GNU/Linux

But I will continue to dig further into this but

@vspinu
Copy link
Member

vspinu commented Mar 11, 2015

I think cl-lib was introduced in 24.4. I have changed it to the old (require 'cl).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants