Don't loose properties in completion-in-region (#2265)

* helm-mode.el (helm-completion-in-region-selection): New. (helm--completion-in-region): Use it in helm-before-action-hook.
emacs-helm · Jan 22, 2020 · 8ed26cb · 8ed26cb
1 parent 203dbe8
commit 8ed26cb
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/helm-mode.el b/helm-mode.el
@@ -1660,6 +1660,10 @@ that is non-nil."
          (all (completion-pcm--all-completions prefix pattern table pred)))
     (list all pattern prefix suffix (car bounds))))
 
+(defun helm-completion-in-region-selection ()
+  (with-helm-buffer
+    (setq helm-saved-selection (helm-get-selection nil 'withprop))))
+
 ;; Completion-in-region-function
 
 (defun helm--completion-in-region (origfun start end collection &optional predicate)
@@ -1679,6 +1683,7 @@ Can be used for `completion-in-region-function' by advicing it with an
       (helm-aif (cdr (assq major-mode helm-completion-styles-alist))
           (customize-set-variable 'helm-completion-style
                                   (if (cdr-safe it) (car it) it)))
+      (add-hook 'helm-before-action-hook 'helm-completion-in-region-selection)
       (unwind-protect
           (let* ((enable-recursive-minibuffers t)
                  (completion-flex-nospace t)
@@ -1818,8 +1823,13 @@ Can be used for `completion-in-region-function' by advicing it with an
                                  (message "[No matches]")))
                               t)        ; exit minibuffer immediately.
                             :must-match require-match))))
-            (setq string result)
+            ;; `helm-completion-in-region--insert-result' is stripping
+            ;; out properties on RESULT and by side-effect (perhaps
+            ;; `choose-completion-string'?) modify STRING so make a copy.
+            (setq string (copy-sequence result))
+            (remove-hook 'helm-before-action-hook 'helm-completion-in-region-selection)
             (helm-completion-in-region--insert-result result start point end base-size))
+        ;; Allow running extra property :exit-function (Issue #2265)
         (completion--done string 'finished)
         (customize-set-variable 'helm-completion-style old--helm-completion-style)
         (setq helm-completion--sorting-done nil)