Skip to content

Commit

Permalink
Fix #2274 completion--done should be called with 'exact
Browse files Browse the repository at this point in the history
as argument in our case, with 'finished, an extra space is added at
insertion which is wrong.

* helm-mode.el (helm--completion-in-region): Do it.
  • Loading branch information
Thierry Volpiatto committed Jan 27, 2020
1 parent 129b9a5 commit 9319b4a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion helm-mode.el
Original file line number Diff line number Diff line change
Expand Up @@ -1833,7 +1833,7 @@ Can be used for `completion-in-region-function' by advicing it with an
(helm-completion-in-region--insert-result result start point end base-size))
;; Allow running extra property :exit-function (Issue #2265)
(when (stringp string)
(completion--done string 'finished))
(completion--done string 'exact))
(remove-hook 'helm-before-action-hook 'helm-completion-in-region--selection)
(customize-set-variable 'helm-completion-style old--helm-completion-style)
(setq helm-completion--sorting-done nil)
Expand Down

0 comments on commit 9319b4a

Please sign in to comment.