Change user-option defvars into defcustoms #50

Closed
haxney opened this Issue May 4, 2012 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

haxney commented May 4, 2012

There are a number of defvar forms which start with "*...", which was the old, pre-defcustom way of declaring that variables be user-editable. That behavior is obsolete, and should be replaced by defcustom forms.

A quick look at things shows the following variables use this old format:

/helm-apt.el:35:helm-apt-installed
/helm-apt.el:40:helm-apt-deinstalled
/helm-bookmark.el:36:helm-bookmark-info
/helm-bookmark.el:41:helm-bookmark-w3m
/helm-bookmark.el:46:helm-bookmark-gnus
/helm-bookmark.el:51:helm-bookmark-man
/helm-bookmark.el:56:helm-bookmark-file
/helm-bookmark.el:61:helm-bookmark-directory
/helm-buffers.el:62:helm-buffer-saved-out
/helm-buffers.el:67:helm-buffer-not-saved
/helm-command.el:39:helm-M-x-key
/helm-elisp.el:60:helm-lisp-show-completion
/helm-elisp.el:65:helm-lisp-completion-info
/helm-emms.el:38:helm-emms-playlist
/helm-files.el:131:helm-ff-exif-data-program-args
/helm-files.el:202:helm-ff-prefix
/helm-files.el:207:helm-ff-executable
/helm-files.el:212:helm-ff-directory
/helm-files.el:217:helm-ff-symlink
/helm-files.el:222:helm-ff-invalid-symlink
/helm-files.el:227:helm-ff-file
/helm-files.el:312:helm-c-find-files-doc-header
/helm-net.el:256:helm-browse-url-default-browser-alist
/helm.el:154:helm-display-source-at-screen-top
/helm.el:158:helm-candidate-number-limit
/helm.el:167:helm-idle-delay

I may have missed some; there's a lot to helm! :)

Owner

thierryvolpiatto commented May 4, 2012

Thanks, I have fixed a lot of defvars, but yes there is a lot of them that need to moved to defcustom especially in helm.el.

@thierryvolpiatto thierryvolpiatto added a commit that referenced this issue Aug 10, 2012

@thierryvolpiatto thierryvolpiatto * helm.el: Issue #50 Move some variables to defcustom and remove * in…
… some places.

(helm-swap-windows): Use -.
45cf362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment