C-z is really hard to hit and RSI causing.

[lewang]

1. Make new binding C-o.
2. Prefer this new binding in documentation.

I can update the wiki once this PR is merged.

[tuhdo]

Yes, the new binding is much better. Please merge it.

[thierryvolpiatto]

It is not what I want for helm. I would prefer extending right arrow key (what we already have in many places) to whole helm (customizable of course). We have already discussed this IIRC and I was against for persistent-action.

[lewang]

What specifically do you object to?

• Adding C-o binding.
• Documenting C-o instead of C-z, although C-z still works.

On Wed, Jul 2, 2014 at 8:31 AM, Thierry Volpiatto notifications@github.com
wrote:

It is not what I want for helm. I would prefer extending right arrow key
(what we already have in many places) to whole helm (customizable of
course). We have already discussed this IIRC and I was against for
persistent-action.

—
Reply to this email directly or view it on GitHub
#547 (comment).

Le

[thierryvolpiatto]

Le Wang notifications@github.com writes:

What specifically do you object to?

I don't see why C-o would be better than C-z.
If one want C-o or whatever, it is configurable AFAIK.
As I said previously I am in favor of using the arrow keys like we do in
*grep, *moccur, *imenu etc...

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

[lewang]

On Wed, Jul 2, 2014 at 10:50 AM, Thierry Volpiatto <notifications@github.com

wrote:

I don't see why C-o would be better than C-z.

C-z is very hard to hit without mangling one's fingers weirdly.

If one want C-o or whatever, it is configurable AFAIK.

Yes absolutely. This is not about removing C-z binding. I'm just
proposing making C-o the preferred binding in the documentation. This
makes it more friendly to new users. Users who are already accustomed to
C-z do not need to change anything.

As I said previously I am in favor of using the arrow keys like we do in

*grep, *moccur, *imenu etc...

The persistent action is one of the most common keystrokes a user makes in
Helm. This is about making the default more ergonomic for new users while
preserving the old behaviour. Arrow keys work but are too out of the way
for such a common command.

Le

[thierryvolpiatto]

Le Wang notifications@github.com writes:

Yes absolutely. This is not about removing C-z binding.

I understood, but again it is not what I want.

Thus C-o is already bound to `helm-next-source'.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

[lewang]

On Wed, Jul 2, 2014 at 12:14 PM, Thierry Volpiatto <notifications@github.com

wrote:

Le Wang notifications@github.com writes:

Yes absolutely. This is not about removing C-z binding.

I understood, but again it is not what I want.

Thus C-o is already bound to `helm-next-source'.

I didn't realize that C-o was bound by default. How about M-o or maybe you
can propose a compromise binding. C-z is just too unergonomic to be the
default.

Le

[rranelli]

+1 for the unergonomics of C-z.

[thierryvolpiatto]

I have now removed C-j and C-e commands, so they are now free, I think using C-j for persistent action would be the best now, maybe you can change C-o to C-j and apply your patch on top of this.

Thanks.

[lewang]

will do today.

[thierryvolpiatto]

Ok I have replaced all occurences of C-z where needed, feel free to reopen if you find some more.