Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp-flycheck is rust specific #33

Closed
mattiasb opened this issue Mar 28, 2017 · 4 comments · Fixed by #35
Closed

lsp-flycheck is rust specific #33

mattiasb opened this issue Mar 28, 2017 · 4 comments · Fixed by #35

Comments

@mattiasb
Copy link

I'm trying out lsp-mode with PyLS and activated lsp-flycheck with lsp-flycheck-setup but it failed since it wanted to run with the Rust checker.

See these lines for why.

@vibhavp
Copy link
Member

vibhavp commented Apr 1, 2017

This line seems to be the primary culprit. I'll make the code independent of language mode, thanks.

@mattiasb
Copy link
Author

mattiasb commented Apr 1, 2017

Not really. That whole sexp defines a flycheck-checker for rust-mode, so I believe it's actually just L62 that is wrong.

From C-h v flycheck-checker:

Documentation:
Syntax checker to use for the current buffer.

If unset or nil, automatically select a suitable syntax checker
from ‘flycheck-checkers’ on every syntax check.

If set to a syntax checker only use this syntax checker and never
select one from ‘flycheck-checkers’ automatically.  The syntax
checker is used regardless of whether it is contained in
‘flycheck-checkers’ or ‘flycheck-disabled-checkers’.  If the
syntax checker is unusable in the current buffer an error is
signaled.

@mattiasb
Copy link
Author

mattiasb commented Apr 1, 2017

Perhaps @fmdkdd could fill us in here?

@fmdkdd
Copy link
Contributor

fmdkdd commented Apr 1, 2017

Ah yes, sorry for that. I only tested it with Rust. I've just pushed a PR to fix that, but beware I did not test it. Let me know if that works for you.

wkirschbaum pushed a commit to wkirschbaum/lsp-mode that referenced this issue Jun 1, 2021
mix.lock had many unused deps. Updated all of them to most recent
ones.

Also cleaned up default generated comments on mix.exs.

Left a REAL important one about NOT starting applications in
elixir_ls_utils application. Took me a while to figure out WHAT was
causing the server to stop working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants