Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: Add semantic token support #3535

Merged
merged 2 commits into from
May 22, 2022

Conversation

psibi
Copy link
Member

@psibi psibi commented May 21, 2022

Summary of the changes:

  • Make these variables buffer local:
    • lsp-semantic-token-faces
    • lsp-semantic-token-modifier-faces

The main reason for it is that a particular client will have more semantic tokens associated with them and making them buffer local makes it work seamlessly across different languages.

  • Convert the variable lsp-semantic-tokens-capabilities to lsp--semantic-tokens-capabilities function so that the initialization
    message to the language server is passed correctly.

  • Add complete semantic token support for terraform lanuage. This has been tested using the official Hashicorps terraform language server.

Summary of the changes:

- Make these variables buffer local:
  - lsp-semantic-token-faces
  - lsp-semantic-token-modifier-faces

The main reason for it is that a particular client will have more
semantic tokens associated with them and making them buffer local
makes it work seamlessly across different languages.

- Convert the variable lsp-semantic-tokens-capabilities to
lsp--semantic-tokens-capabilities function so that the initialization
message to the language server is passed correctly.

- Add complete semantic token support for terraform lanuage. This has
been tested using the official Hashicorps terraform language server.
@github-actions github-actions bot added client One or more of lsp-mode language clients semantic-tokens labels May 21, 2022
Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericdallo ericdallo merged commit eac730f into emacs-lsp:master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients semantic-tokens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants