Add credo-language-server support #4068

wkirschbaum · 2023-06-11T15:10:41Z

This is a linting server for the Elixir programming language.

clients/lsp-credo.el: New file.
docs/lsp-clients.json: Add credo-ls entry.
lsp-mode.el: Add directory for server cache.
CHANGELOG.org: Add entry.

This is a linting server for the Elixir programming language. * clients/lsp-credo.el: New file. * docs/lsp-clients.json: Add credo-ls entry. * lsp-mode.el: Add directory for server cache. * CHANGELOG.org: Add entry.

wkirschbaum · 2023-06-11T16:28:14Z

This is exclusively for elixir-mode, elixir-ts-mode and heex-ts-mode ( The Elixir langauges ). Does it make sense as a separate file? Feels cleaner.

yyoncho · 2023-06-11T16:32:15Z

clients/lsp-credo.el

@@ -0,0 +1,61 @@
+;;; lsp-credo.el --- lsp-mode Credo integration -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2022 emacs-lsp maintainers


nit: 2023, your name

yyoncho · 2023-06-11T16:33:50Z

clients/lsp-credo.el

+  :download-server-fn (lambda (_client callback error-callback _update?)
+                        (lsp-package-ensure 'credo-ls callback error-callback))))


I dont see a setup for automatic installation?

@yyoncho i am a bit unsure on how this works. its a repo download and unzip... let me try to add it now.

@yyoncho latest changes has the setup for automatic installation. Pretty neat feature :).

* clients/lsp-credo.el: Add automatic installation.

mhanberg · 2023-06-11T19:35:38Z

clients/lsp-credo.el

+  :package-version '(lsp-mode . "8.0.1"))
+
+(defcustom lsp-credo-download-url
+  (format (concat "https://github.com/elixir-tools/credo-language-server"


Will it be easier for you if i make sure the bin/credo-language-server script is always uploaded as an asset on the github release?

Thanks, i updated the PR to use the new release file structure.

jcs090218 · 2023-06-11T20:29:18Z

You might want to add the new client to lsp-client-packages:

lsp-mode/lsp-mode.el

Lines 176 to 193 in 9e51079

    
           (defcustom lsp-client-packages 
        
             '( ccls lsp-actionscript lsp-ada lsp-angular lsp-ansible lsp-astro lsp-bash 
        
                lsp-beancount lsp-clangd lsp-clojure lsp-cmake lsp-crystal lsp-csharp lsp-css 
        
                lsp-d lsp-dart lsp-dhall lsp-docker lsp-dockerfile lsp-elm lsp-elixir lsp-emmet 
        
                lsp-erlang lsp-eslint lsp-fortran lsp-fsharp lsp-gdscript lsp-go lsp-gleam 
        
                lsp-glsl lsp-graphql lsp-hack lsp-grammarly lsp-groovy lsp-haskell lsp-haxe 
        
                lsp-idris lsp-java lsp-javascript lsp-json lsp-kotlin lsp-latex lsp-ltex 
        
                lsp-lua lsp-markdown lsp-marksman lsp-mint lsp-nginx lsp-nim lsp-nix lsp-magik 
        
                lsp-metals lsp-mssql lsp-ocaml lsp-openscad lsp-pascal lsp-perl lsp-perlnavigator 
        
                lsp-pls lsp-php lsp-pwsh lsp-pyls lsp-pylsp lsp-pyright lsp-python-ms lsp-purescript 
        
                lsp-r lsp-racket lsp-remark lsp-ruff-lsp lsp-rf lsp-rust lsp-semgrep lsp-shader lsp-solargraph 
        
                lsp-sorbet lsp-sourcekit lsp-sonarlint lsp-tailwindcss lsp-tex lsp-terraform 
        
                lsp-toml lsp-ttcn3 lsp-typeprof lsp-v lsp-vala lsp-verilog lsp-vetur lsp-volar 
        
                lsp-vhdl lsp-vimscript lsp-xml lsp-yaml lsp-ruby-lsp lsp-ruby-syntax-tree 
        
                lsp-sqls lsp-svelte lsp-steep lsp-tilt lsp-zig) 
        
             "List of the clients to be automatically required." 
        
             :group 'lsp-mode 
        
             :type '(repeat symbol))

wkirschbaum · 2023-06-11T20:35:32Z

@jcs090218 thanks, added.

lsp-mode.el

* lsp-mode.el (lsp-client-packages): Add lsp-credo.

The client does not support multi root workspaces yet.

yyoncho · 2023-06-24T14:32:32Z

Thank you for contributing to lsp-mode!

github-actions bot added client One or more of lsp-mode language clients documentation labels Jun 11, 2023

wkirschbaum force-pushed the add-credo-ls branch 2 times, most recently from a11e695 to 0356943 Compare June 11, 2023 15:20

Add credo-language-server support

1f13d8f

This is a linting server for the Elixir programming language. * clients/lsp-credo.el: New file. * docs/lsp-clients.json: Add credo-ls entry. * lsp-mode.el: Add directory for server cache. * CHANGELOG.org: Add entry.

wkirschbaum force-pushed the add-credo-ls branch from 0356943 to 1f13d8f Compare June 11, 2023 16:16

yyoncho reviewed Jun 11, 2023

View reviewed changes

wkirschbaum added 2 commits June 11, 2023 18:35

Fix lsp-credo copyright

b2bd768

Add automatic installation to lsp-credo

8246f4e

* clients/lsp-credo.el: Add automatic installation.

wkirschbaum force-pushed the add-credo-ls branch from c04a214 to 8246f4e Compare June 11, 2023 18:28

wkirschbaum mentioned this pull request Jun 11, 2023

docs: update emacs lsp-mode instructions elixir-tools/credo-language-server#60

Merged

mhanberg reviewed Jun 11, 2023

View reviewed changes

Use new download link for lsp-credo

8af6e66

jcs090218 reviewed Jun 11, 2023

View reviewed changes

lsp-mode.el Outdated Show resolved Hide resolved

Add lsp-credo to lsp-client-packages

07393ba

* lsp-mode.el (lsp-client-packages): Add lsp-credo.

wkirschbaum force-pushed the add-credo-ls branch from cdce6be to 07393ba Compare June 11, 2023 20:41

wkirschbaum mentioned this pull request Jun 12, 2023

tree-sitter support elixir-editors/emacs-elixir#494

Closed

Set multi-root to nil for lsp-credo

f04d0db

The client does not support multi root workspaces yet.

yyoncho approved these changes Jun 24, 2023

View reviewed changes

yyoncho merged commit 48eefee into emacs-lsp:master Jun 24, 2023

wkirschbaum deleted the add-credo-ls branch June 24, 2023 22:53

		@@ -0,0 +1,61 @@
		;;; lsp-credo.el --- lsp-mode Credo integration -- lexical-binding: t; --

		;; Copyright (C) 2022 emacs-lsp maintainers

		:download-server-fn (lambda (_client callback error-callback _update?)
		(lsp-package-ensure 'credo-ls callback error-callback))))

Uh oh!

Add credo-language-server support #4068

Add credo-language-server support #4068

Uh oh!

Conversation

wkirschbaum commented Jun 11, 2023

Uh oh!

wkirschbaum commented Jun 11, 2023

Uh oh!

yyoncho Jun 11, 2023

Choose a reason for hiding this comment

Uh oh!

wkirschbaum Jun 11, 2023

Choose a reason for hiding this comment

Uh oh!

yyoncho Jun 11, 2023

Choose a reason for hiding this comment

Uh oh!

wkirschbaum Jun 11, 2023

Choose a reason for hiding this comment

Uh oh!

wkirschbaum Jun 11, 2023

Choose a reason for hiding this comment

Uh oh!

mhanberg Jun 11, 2023

Choose a reason for hiding this comment

Uh oh!

wkirschbaum Jun 11, 2023

Choose a reason for hiding this comment

Uh oh!

jcs090218 commented Jun 11, 2023

Uh oh!

wkirschbaum commented Jun 11, 2023

Uh oh!

Uh oh!

yyoncho commented Jun 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants