-
-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add credo-language-server support #4068
Conversation
a11e695
to
0356943
Compare
This is a linting server for the Elixir programming language. * clients/lsp-credo.el: New file. * docs/lsp-clients.json: Add credo-ls entry. * lsp-mode.el: Add directory for server cache. * CHANGELOG.org: Add entry.
0356943
to
1f13d8f
Compare
This is exclusively for elixir-mode, elixir-ts-mode and heex-ts-mode ( The Elixir langauges ). Does it make sense as a separate file? Feels cleaner. |
clients/lsp-credo.el
Outdated
@@ -0,0 +1,61 @@ | |||
;;; lsp-credo.el --- lsp-mode Credo integration -*- lexical-binding: t; -*- | |||
|
|||
;; Copyright (C) 2022 emacs-lsp maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 2023, your name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
clients/lsp-credo.el
Outdated
:download-server-fn (lambda (_client callback error-callback _update?) | ||
(lsp-package-ensure 'credo-ls callback error-callback)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see a setup for automatic installation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yyoncho i am a bit unsure on how this works. its a repo download and unzip... let me try to add it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yyoncho latest changes has the setup for automatic installation. Pretty neat feature :).
* clients/lsp-credo.el: Add automatic installation.
c04a214
to
8246f4e
Compare
:package-version '(lsp-mode . "8.0.1")) | ||
|
||
(defcustom lsp-credo-download-url | ||
(format (concat "https://github.com/elixir-tools/credo-language-server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be easier for you if i make sure the bin/credo-language-server script is always uploaded as an asset on the github release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, i updated the PR to use the new release file structure.
You might want to add the new client to Lines 176 to 193 in 9e51079
|
@jcs090218 thanks, added. |
* lsp-mode.el (lsp-client-packages): Add lsp-credo.
cdce6be
to
07393ba
Compare
The client does not support multi root workspaces yet.
Thank you for contributing to |
This is a linting server for the Elixir programming language.