Fix project root discovery when project features aren't loaded. #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for the corresponding project package (i.e., projectile or project) to not be loaded yet but there to exist autoloads for the functions. In that situation, using `featurep` to check for the existence of the package will fail. Therefore, `fboundp` is used instead to check for the existence (possibly an autoload) of the needed functions.
jcs090218
approved these changes
May 27, 2024
|
Make sense. Thank you! |
cheerio-pixel
pushed a commit
to cheerio-pixel/lsp-mode
that referenced
this pull request
May 29, 2024
…s-lsp#4463) It's possible for the corresponding project package (i.e., projectile or project) to not be loaded yet but there to exist autoloads for the functions. In that situation, using `featurep` to check for the existence of the package will fail. Therefore, `fboundp` is used instead to check for the existence (possibly an autoload) of the needed functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for the corresponding project package (i.e., projectile or project) to not be loaded yet but there to exist autoloads for the functions. In that situation, using
featurepto check for the existence of the package will fail. Therefore,fboundpis used instead to check for the existence (possibly an autoload) of the needed functions.