-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto select-window on find references/implementations #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but I want to check with @yyoncho before merging because we were discussing about this behaviour before: If we want to keep the current behaviour when the command is invoked with a prefix argument, or if we can implement that in a later PR.
IIRC, the key UX aspect to consider is that the operation that loads references in lsp-mode
is asynchronous and you'll jump to a "Loading..." window for a moment. I've never found any server slow enough for this to be noticeable.
Thanks @danielmartin, I understand and I really hope we find a solution because I want to replace my |
@ericdallo willing to implement the following behavior? M-x lsp-treemacs-references - switches to the window.
JDT LS could take 20+ seconds. I think that ccls/clangd have everything precalculated and they just return the result. |
@yyoncho, Can I use the If not, can you give some suggestions on how I can achieve that? Checking if the |
Ah, I totally forgot about that, sorry: Can we then make it like that: C-0 M-x lsp-treemacs-references - async call(this is equivalent to prefix = 0). |
Done @yyoncho
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one comment:
Done @yyoncho, thanks! |
Thank you for contributing to |
Currently when you use
lsp-treemacs-errors-list
, automatically jumps to the new buffer showing the errors, butlsp-treemacs-references
don't do that.This PR fixes
lsp-treemacs-references
andlsp-treemacs-implementations
to jump likelsp-treemacs-errors-list