peek reference errors

[kvaneesh]

I use lsp-ui-peek-find-references to find the references. Then i select a file using [ENTER]. After that using xref-pop-marker-stack gets be back to window with peek window/overlay but not able to close that window.

[sebastiencs]

not able to close that window

I'm not sure to understand, which window cannot you close ?

[MaskRay]

If you use evil you may try lsp-ui-peek-jump-{backward,forward} .

xref-pop-marker-stack is shared by all windows

[kvaneesh]

Steps:

1. Search for references.
2. Select one of the file and visit the file/[ENTER]
3. Go back with lsp-ui-peek-jump-backward. We get to a buffer/window with peek window/overlay still present. There is no way to close that peek window/overlay. Clicking around that buffer removes the overlay. But it would be nice to get back to a buffer without overlay in there?

[MaskRay]

Yeah I also come across this occasionally.

[MaskRay]

1a7b627 probably fixed this issue.

FYI I hope you would be interested at https://github.com/emacs-lsp/lsp-ui/blob/master/lsp-ui.el#L119
it is very inefficient now

This is interesting because it only happens in Evil mode. I'm still unclear why emacs mode is not bothered by this.

calling (lsp-ui-peek-mode -1) will invalidate marker used in (if other-window (pop-to-buffer (marker-buffer marker)) (switch-to-buffer (marker-buffer marker)))