[lsp-ui-peek] Generalize lsp-ui-peek-force-fontify to lsp-ui-peek-fontify and add another choice 'on-demand #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaskRay
changed the title
…tify and add another choice 'on-demand 'on-demand fontifies the chunk when the selection changes.
MaskRay
added a commit
to MaskRay/spacemacs
that referenced
this pull request
Sep 2, 2018
lsp-ui has switched to (defcustom lsp-ui-peek-fontify 'on-demand ...) emacs-lsp/lsp-ui#148 . This is no longer needed.
sdwolfz
pushed a commit
to syl20bnr/spacemacs
that referenced
this pull request
Sep 3, 2018
lsp-ui has switched to (defcustom lsp-ui-peek-fontify 'on-demand ...) emacs-lsp/lsp-ui#148 . This is no longer needed.
CodingSolo
pushed a commit
to CodingSolo/spacemacs
that referenced
this pull request
Oct 29, 2018
lsp-ui has switched to (defcustom lsp-ui-peek-fontify 'on-demand ...) emacs-lsp/lsp-ui#148 . This is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'on-demandfontifies the chunk when the selection changes.I have indexed compiler-rt with ccls and checked a common identifier
uptrwhich has 2000 references (cutoff because of the initialization optionxref.maxNum). It is no slower than'neverthough a bit slower when I triggerlsp-ui-peek--select-nextcontinuously. But I think this should be ok.