New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix peek--get-references
for lsp-use-plists
#743
Conversation
73c2413
to
c8c88bf
Compare
@yyoncho, can |
@erikarvstedt the solution is usually to use |
@yyoncho, using Which JSON objects in server responses are deserialised as vectors? |
@erikarvstedt vector is returned for json vectors when using native json deserialization. When it is not used - you get list. |
Alright, then this PR can be merged. |
c8c88bf
to
c14a8c5
Compare
In general lsp-use-plists should not be used outside of lsp-protocol.el |
c14a8c5
to
f8b9cf4
Compare
Fixed. |
When `lsp-use-plists` is t, `lsp-request` returns a single plist (of form (:key val ...) or a list of plists. Previously, when `lsp-use-plists` was t and a single plist was returned, the plist wasn't wrapped into a list, causing the subsequent code to fail.
f8b9cf4
to
4f2382d
Compare
This fixes
lsp-ui-peek-find-definitions/references
whenlsp-use-plists
ist
and a single item is returned by the server.Copy of commit msg
When
lsp-use-plists
is t,lsp-request
returns a single plist (of form(:key val ...)
or a list of plists.Previously, when
lsp-use-plists
was t and a single plist was returned, the plist wasn't wrapped into a list, causing the subsequent code to fail.