Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement annotation highlighting #8

Closed
exu opened this issue Oct 4, 2011 · 6 comments
Closed

Implement annotation highlighting #8

exu opened this issue Oct 4, 2011 · 6 comments

Comments

@exu
Copy link
Contributor

exu commented Oct 4, 2011

Hi Eric,

Great job with this mode. It would be cool to have annotations highlighting like in symfony2/doctrine2
http://symfony.com/doc/current/book/doctrine.html

@ejmr
Copy link
Collaborator

ejmr commented Oct 4, 2011

Thanks a lot. I'll put this on my list of things to do.

@ejmr
Copy link
Collaborator

ejmr commented Oct 7, 2011

I'm making some progress on this. Initially the highlighting support will probably be simply for the annotations that appear in Symfony, although I'm looking for a more general solution. I would like to provide special highlighting to anything starting with '@' but that would conflict with the use of '@' outside of comments.

@dmj
Copy link
Contributor

dmj commented Oct 14, 2012

@ejmr
Copy link
Collaborator

ejmr commented Oct 15, 2012

Thank you dmj for the code. Is this code you wrote? I just want to make sure I attribute it to the right person if I end up applying it to php-mode.

@dmj
Copy link
Contributor

dmj commented Oct 15, 2012

Yes, that's my production. Attribution would be: David Maus dmaus@ictsoc.de -- Originally I wanted to publish this as a standalone package `php-annotations' with extended support for different annotation types (phpdoc, phpunit etc.) but decided that it is not worth the effort to write such extended support. Having the annotations hightlighted is good enough for me.

@ejmr
Copy link
Collaborator

ejmr commented Oct 15, 2012

Thank you for the contribution dmj. I added your code into php-mode and updated the master branch with it. If you add more detailed support for annotations please let me know. I'd certainly welcome support for those.

@ejmr ejmr closed this as completed Oct 15, 2012
haxney added a commit to haxney/php-mode that referenced this issue Jan 28, 2013
haxney added a commit to haxney/php-mode that referenced this issue Jan 28, 2013
ejmr pushed a commit that referenced this issue Jan 28, 2013
* haxney/ert-tests:
  Mark tests 9, 14, and 19 as expected failures.
  ERT tests for remaining example files.
  Require `php-mode` in `php-mode-test.el`, duh.
  ERT test for #19
  ERT tests for issues 14, 16, and 18
  ERT test for issue #8.
  Create ERT-based test for issue #9.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants