Fix visit_in_email opens the wrong link #177 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, what is the status of it? |
|
@Hirurg103 it looks good to me. Thank you! 👍 |
| # e.g. Click here in <a href="http://confirm">Click here</a> | ||
| def parse_email_for_anchor_text_link(email, link_text) | ||
| if textify_images(email.default_part_body) =~ %r{<a[^>]*href=['"]?([^'"]*)['"]?[^>]*?>[^<]*?(.*?)#{link_text}(.*?)[^<]*?</a>} | ||
| if textify_images(email.default_part_body) =~ %r{<a[^>]*#{HrefRegex}[^>]*>#{NotClosingARegex}#{link_text}#{NotClosingARegex}</a>} |
There was a problem hiding this comment.
@Hirurg103 looks good so far! could you use ruby constants for the begin and the end? I think that could clear the code up, otherwise it looks a little confusing.
There was a problem hiding this comment.
@Hirurg103 nevermind, thanks a lot for your contribution! 👍
There was a problem hiding this comment.
ok, thank you for accepting this PR 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.