Merge pull request #5 from asutherland/semicolons-as-delim

Treat semicolons as a delimiter outside of groups.

src/addressparser.js

@@ -237,7 +237,15 @@
         "(": ")",
         "<": ">",
         ",": "",
-        ":": ";"
+        // Groups are ended by semicolons
+        ":": ";",
+        // Semicolons are not a legal delimiter per the RFC2822 grammar other
+        // than for terminating a group, but they are also not valid for any
+        // other use in this context.  Given that some mail clients have
+        // historically allowed the semicolon as a delimiter equivalent to the
+        // comma in their UI, it makes sense to treat them the same as a comma
+        // when used outside of a group.
+        ";": ""
     };
 
     /**

test/addressparser-unit.js

@@ -53,6 +53,15 @@
                 expect(addressparser.parse(input)).to.deep.equal(expected);
             });
 
+            it("should handle quoted semicolons correctly", function() {
+                var input = "\"reinman; andris\" <andris@tr.ee>",
+                    expected = [{
+                        name: "reinman; andris",
+                        address: "andris@tr.ee"
+                    }];
+                expect(addressparser.parse(input)).to.deep.equal(expected);
+            });
+
             it("should handle unquoted name, unquoted address correctly", function() {
                 var input = "andris andris@tr.ee",
                     expected = [{
@@ -86,6 +95,18 @@
                 expect(addressparser.parse(input)).to.deep.equal(expected);
             });
 
+            it("should handle semicolon as a delimiter", function() {
+                var input = "andris@tr.ee; andris@example.com;",
+                    expected = [{
+                        address: "andris@tr.ee",
+                        name: ""
+                    }, {
+                        address: "andris@example.com",
+                        name: ""
+                    }];
+                expect(addressparser.parse(input)).to.deep.equal(expected);
+            });
+
             it("should handle mixed group correctly", function() {
                 var input = "Test User <test.user@mail.ee>, Disclosed:andris@tr.ee, andris@example.com;,,,, Undisclosed:;",
                     expected = [{
@@ -107,6 +128,30 @@
                 expect(addressparser.parse(input)).to.deep.equal(expected);
             });
 
+            it("semicolon as delimiter should not break group parsing ", function() {
+                var input = "Test User <test.user@mail.ee>; Disclosed:andris@tr.ee, andris@example.com;,,,, Undisclosed:; bob@example.com;",
+                    expected = [{
+                        "address": "test.user@mail.ee",
+                        "name": "Test User"
+                    }, {
+                        "name": "Disclosed",
+                        "group": [{
+                            "address": "andris@tr.ee",
+                            "name": ""
+                        }, {
+                            "address": "andris@example.com",
+                            "name": ""
+                        }]
+                    }, {
+                        "name": "Undisclosed",
+                        "group": []
+                    }, {
+                        "address": "bob@example.com",
+                        "name": ""
+                    }];
+                expect(addressparser.parse(input)).to.deep.equal(expected);
+            });
+
             it("should handle name from comment correctly", function() {
                 var input = "andris@tr.ee (andris)",
                     expected = [{